-
Notifications
You must be signed in to change notification settings - Fork 4
Kwon ju hwan #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
KwonJuHwan
wants to merge
33
commits into
boocam-project:KwonJuHwan
Choose a base branch
from
KwonJuHwan:KwonJuHwan
base: KwonJuHwan
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Kwon ju hwan #1
Changes from 1 commit
Commits
Show all changes
33 commits
Select commit
Hold shift + click to select a range
8238f3e
User -> Member 변경
KwonJuHwan c8c7952
DTO로 받아오는 환경 설정을 위해 MemberDTO 생성
KwonJuHwan 8e00cf0
회원 가입 성공 / 실패(아이디를 작성하지 않음)구현
KwonJuHwan abfd5ae
Member 객체를 저장하기 위한 메소드 : save,
KwonJuHwan fe5a769
Transaction환경에서 회원가입 메소드 구현:join
KwonJuHwan 9cd2ed1
username
KwonJuHwan c2d8b75
Mock을 이용한 Controller Test
KwonJuHwan bc4704d
Controller: 회원가입 구현
KwonJuHwan dc88196
로그인 테스트 성공 / 실패 Test
KwonJuHwan 4062461
로그인용 DTO 생성
KwonJuHwan d58abb9
equals를 위한 메소드 구현
KwonJuHwan 0aa291c
Vaildation 오류 수정
KwonJuHwan 80a2ab1
기존 Test 통합 및 Servive 테스트와 Controller 테스트 분리
KwonJuHwan 99b4655
Default Constructor 추가
KwonJuHwan 9a56bad
Controller 로직 변경 (Service에서 로직 실행)
KwonJuHwan 443c1d5
비밀번호 재확인, 아이디,비밀번호 확인 로직 추가
KwonJuHwan da5f9e8
NPE 제거를 위해 Optional 사용
KwonJuHwan 5e28932
Service Test 추가
KwonJuHwan 9820479
등급 업 Test 추가
KwonJuHwan 1a7c45e
Admin 계정 만들기 추가
KwonJuHwan 5cd9521
기존 Test 삭제
KwonJuHwan b4f779c
사용하지않은 Autowired 삭제
KwonJuHwan 7d82f93
[Day 3-4] 상품 서비스 테스트 추가
KwonJuHwan 0f684c5
[Day 3-4] 상품 리포지토리 추가
KwonJuHwan 0be9d21
[Day 3-4] 상품 등록을 위한 상품 DTO 추가
KwonJuHwan 24b6ca6
[Day 3-4] 상품 등록 메소드, 상품 주문 가능 여부 판단 메소드 추가
KwonJuHwan f98dc6d
[Day 3-4] 상품 구매-> 재고 -1 메소드 추가 , SellingStatus를 바꾸는 메소드 추가
KwonJuHwan 557eb5d
[Day 3-4] 상품 컨트롤러 테스트 추가
KwonJuHwan 82cc88f
[Day 3-4] 상품 컨트롤러 추가
KwonJuHwan 3e779dc
[Day 3-4] 상품 Validation 추가
KwonJuHwan 747627c
[Day 3-4] 팀원분들의 피드백 반영
KwonJuHwan 61ec120
[Day 3-4] 팀원분들의 피드백 반영
KwonJuHwan 1012a3d
[Day 3-4] 팀원분들의 피드백 반영 3
KwonJuHwan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
상품 명에 빈칸이 필요할 수도 있지 않을까 생각해봤습니다! @NotNull로 변경하면 띄어쓰기를 허용할 수 있습니다 ㅎㅎ
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
상품명에 빈칸이 필요한 경우가 구체적으로 어떤 것이 있을까요? 상품명이 빈칸 =
" "인 경우는 상품명이 없다고 판단하여 묶어서 테스트를 진행하였는데 의견 부탁드립니다!There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
제가 생각했던 빈칸이 필요한 경우는 예를 들어, "탈모 방지 샴푸" 와 같이 상품명에 띄어쓰기가 들어있는 경우였습니다! 😊
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@notblank는 글자 없이 " " 이렇게 띄어쓰기만 사용자가 입력하는 경우에만 예외를 터트리는 걸로 알고 있어요! 글자 사이에 있는 블랭크는 예외를 터트리지 않는 걸로 알고 있슴다
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
오 그렇군요! 제가 잘못 이해했나 보네요😅 알려주셔서 감사합니다! 제 코드를 수정해야겠네요 하하 👍🏻