Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eb/자주쓰이는 atom component 구현 및 molecule component 일부 구현 #98

Merged
merged 11 commits into from
Nov 5, 2020

Conversation

Eunbin-Kim
Copy link
Contributor

atom component 구현 및 molecule component 일부 구현

atom component 구현

  • input
    • date picker 구현
    • textarea 구현
    • input label 구현
  • filter
    • filter button 구현
    • filter item의 atom 인 title, description, color swatch 구현

molecule component 일부 구현

  • filter item 중 label 부분 구현

#68 #72 #74 #76

- date picker 컴포넌트 view 구현
- storybook test code 작성
- filter button 컴포넌트 view 구현
- story test code 작성
issue number: #68
- input 위에 붙일 label 컴포넌트 view 구현
- story test code 작성
- textarea 컴포넌트 view 구현
- story test code 작성
issue number: #76
- label tag 컴포넌트 view 구현
- story test code 작성
issue number: #72
- filter item 중 label 부분 atom 조합하여 구현
- storybook test code 작성
issue number: #74
- input element style 공통 부분 같이 사용할 수 있도록 common style 로 따로 선언
@Eunbin-Kim Eunbin-Kim added enhancement New feature or request view 컴포넌트 view만 개발 labels Nov 4, 2020
@Eunbin-Kim Eunbin-Kim added this to the Component milestone Nov 4, 2020
@Eunbin-Kim Eunbin-Kim self-assigned this Nov 4, 2020
background-color: ${({ theme }) => theme.palette.BG_COLOR01};
font-size: 0.8rem;
color: ${({ theme }) => theme.palette.PRIMARY};
border-radius: 0.5rem;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

단위를 통일해 주셔서 좋습니다!

Copy link
Member

@cyjo9603 cyjo9603 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

전체적으로 깔끔하게 잘 작성하신 것 같습니다.

import InputLabel from './InputLabel';

export default {
title: 'Components/InputLabel',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

storybook 에서 한번 더 구분하는거 좋습니다 👍

- 불필요한 파일경로 alias 수정
Copy link
Member

@cyjo9603 cyjo9603 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

죠습니다 👍👍

@cyjo9603 cyjo9603 merged commit dfa2af4 into feature/components Nov 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request view 컴포넌트 view만 개발
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants