-
Notifications
You must be signed in to change notification settings - Fork 0
[Feature] Kakao API 전환 및 장소 검색 Paging 적용 #54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
GwonDongHyeon21
wants to merge
18
commits into
dev
Choose a base branch
from
feature/50-search-paging
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HJunng
approved these changes
Jan 1, 2026
Collaborator
HJunng
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
공통 컴포넌트를 엄청 잘 만들어주셨군요!
검색어 없을 때 처리한 것까지 좋네요..! 고생하셨습니다~
client/data/src/main/java/com/andone/memorip/data/di/NetworkModule.kt
Outdated
Show resolved
Hide resolved
hoyadong1
approved these changes
Jan 1, 2026
Collaborator
hoyadong1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
변경하시느라 고생하셨습니다.
시간 나실때, 네이버랑 카카오 api 비교 문서도 정리하시면 좋을 듯 합니다
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 변경 사항
Naver 검색 API를 Kakao 검색 API로 전환하고 Paging3를 적용하여 무한 스크롤 기능을 구현했습니다.
🎯 작업 내용
API 전환
Paging3 적용
UI 컴포넌트
데이터 직렬화
🔗 관련 이슈
Closes #50
📸 스크린샷 (선택사항)
💬 리뷰어에게
local.properties에 Kakao API 키 설정이 필요합니다.