-
Notifications
You must be signed in to change notification settings - Fork 0
Feature/#19 api response #24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
CDHyun
wants to merge
18
commits into
dev
Choose a base branch
from
feature/#19-api-response
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔍 변경 사항
BaseResponse정의CommonResponseCode정의🔗 관련 이슈
✅ 체크리스트
리뷰 요청
D-Day 계산은 어디서 할 것인지?
오늘 팀 회의에서 깜빡하고 말씀을 못 드렸던 부분이 있어서 남깁니다!

저희 다가오는 초대나 초대장 리스트 등에서 D-Day를 보여주는 기능이 있습니다.
이 부분을 서버에서 계산해서 내려줄 것인지, 클라이언트에서 계산할 것인지를 정하면 좋을 것 같습니다!
현재는 Response에 D-Day 필드까지 넣어놓은 상태인데,
정해지는 방향에 따라서 변경하도록 하겠습니다.
Entity 분리를 하는 것이 좋을지?
현재는 하위 Entity를 분리하지 않고 부모 Entity 밑에 선언해뒀습니다. (GuestBook 하위에 GuestBookVideo 등)
이 부분을 외부 파일로 분리하는 것이 좋을지 현재 형태도 괜찮을지 의견 주시면 감사하겠습니다.
리스트형 필드에 대한 대응
필드에 리스트형식으로 데이터가 들어가야 하는 필드가 있습니다.
MySQL에서 5.7 버전부터 JSON 형식으로 저장이 가능한 것으로 알고 있는데,
지금 형태 (리스트 -> 문자열 -> 문자열로 저장 -> 문자열 불러옴 -> 리스트로 변환)를 유지하는 것이 좋을지
JSON 형태로 저장하는 것이 좋을지 의견을 주시면 감사하겠습니다.