Skip to content
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions frontend/src/components/common/button/Button.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ const style: {
} = {
base: 'inline-flex items-center justify-center box-border select-none m-0 p-0 w-fit h-fit cursor-pointer disabled:cursor-default',
size: {
sm: 'h-full max-h-[50px] px-3 py-[6px] text-sm font-bold',
sm: 'h-full h-auto px-3 py-[6px] text-sm font-bold',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

px-[6px]로 작성하면 혹시 VSCODE에서

The class `px-[6px]` can be written as `px-1.5`(suggestCanonicalClasses)

이런 Warning 밑줄 안생기나요??

저도 저렇게 했었다가 최근 Tailwind에선 저렇게 경고가 생겨서 .5나 .25 등의 기능을 사용하는 편이라 질문 드려요!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

className에서 쓸 땐 warning이 뜨는데 style 정의로 작성했다보니 안 뜬 것 같아요! 놓친 부분이었는데 감사합니다~

lg: 'w-full h-full max-h-[52px] py-4 px-2 text-base font-bold',
},
shape: {
Expand All @@ -20,7 +20,7 @@ const style: {
},
color: {
active: 'text-white', // TODO: 버튼 호버 시 활성화되는 스타일
primary: 'bg-sky-600 text-white', // sky
primary: 'bg-sky-600 text-white hover:bg-sky-700', // sky
secondary: 'bg-sky-700 text-white', // dark-sky
outlinePrimary: 'bg-white border border-sky-600 text-sky-600',
disabled: 'bg-neutral-500 text-white', // ex. 취소 버튼
Expand Down