function_ref should not always reference qualify parameters
#15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By accepting `Args&&...`, a function that accepts its arguments by value is required to accept only rvalues. Instead, we should accept `Args...` (the exact argument types listed in the signature), which allows by-value parameters to copy from lvalue arguments.
|
This change is probably correct but it should include a corresponding test (that fails before the change and passes after it.) |
|
This has been addressed by #17 Let me know if I missed anything or if we need to re-open this. Thank you, David. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By accepting
Args&&..., a function that accepts its arguments by value is required to accept only rvalues. Instead, we should acceptArgs...(the exact argument types listed in the signature), which allows by-value parameters to copy from lvalue arguments.