[CMAKE] CYGWIN: use GCC instead of AS for building ASM #310
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Compiling on CYGWIN shows this error when building assembly sources: /usr/bin/as: unrecognized option `-x' ninja: build stopped: subcommand failed. CMakeLists.txt applies "-x assembler-with-cpp" but this option is expected to work only gcc or g++ drivers are called. Instead, during configuration, CMake prints this: -- Found assembler: /usr/bin/as But this is wrong, because -x option is not recognized by gas. This happens because CMakeLists.txt forces ASM-ATT which excludes gcc and it uses as instead. But it does it ONLY for CYGWIN and actually it is not possible to understand why it has been done. The solution of the problem is to let CMake using GCC instead of AS, by simply removing ASM-ATT and use ASM instead. After that, CMake prints this during the configuration: -- Found assembler: /usr/bin/cc and context is now built without problems after this patch.
|
did you run the unit-test? |
Actually not, I'm still not able to build all boost libraries because other errors. However, and only for CYGWIN, if you force to use |
|
The PR will only be accepted if the tests are executed correctly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compiling on CYGWIN shows this error when building assembly sources:
CMakeLists.txt applies
-x assembler-with-cppbut this option is expected to work only ifgccorg++drivers are called.Instead, during configuration, CMake prints this:
But this is wrong, because
-xoption is not recognized byas.This happens because CMakeLists.txt forces ASM-ATT which excludes
gccand it usesasinstead.But it does this ONLY for CYGWIN and actually it is not possible to understand why it has been done.
The solution of the problem is to let CMake using
gccinstead ofas, by simply removing ASM-ATT and use ASM instead.After that, CMake prints this during the configuration:
and context is now built without problems after this patch.
See also #309 for additional details.