-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: removed unused functionality and minor changes preparing next PR #1358
Merged
barendgehrels
merged 1 commit into
boostorg:develop
from
barendgehrels:refactor/remove-unused
Jan 10, 2025
Merged
refactor: removed unused functionality and minor changes preparing next PR #1358
barendgehrels
merged 1 commit into
boostorg:develop
from
barendgehrels:refactor/remove-unused
Jan 10, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
40f3c97
to
44602ef
Compare
barendgehrels
commented
Jan 1, 2025
include/boost/geometry/algorithms/detail/overlay/enrich_intersection_points.hpp
Show resolved
Hide resolved
barendgehrels
commented
Jan 1, 2025
include/boost/geometry/algorithms/detail/overlay/enrich_intersection_points.hpp
Show resolved
Hide resolved
barendgehrels
commented
Jan 1, 2025
include/boost/geometry/algorithms/detail/overlay/enrich_intersection_points.hpp
Show resolved
Hide resolved
barendgehrels
commented
Jan 1, 2025
include/boost/geometry/algorithms/detail/overlay/enrich_intersection_points.hpp
Show resolved
Hide resolved
barendgehrels
commented
Jan 1, 2025
barendgehrels
commented
Jan 1, 2025
barendgehrels
commented
Jan 1, 2025
barendgehrels
commented
Jan 1, 2025
include/boost/geometry/algorithms/detail/overlay/less_by_segment_ratio.hpp
Show resolved
Hide resolved
07f419e
to
baf2da2
Compare
barendgehrels
commented
Jan 1, 2025
tinko92
reviewed
Jan 2, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (one note in in-line comment).
b091257
to
c0d13f8
Compare
c0d13f8
to
3589d5e
Compare
tinko92
approved these changes
Jan 4, 2025
vissarion
approved these changes
Jan 10, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not deeply understand the code but to my understanding the changes are OK. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This relatively small PR removes things and changes a few minor things.
It prepares the next PR which will change traversal.