Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: removed unused functionality and minor changes preparing next PR #1358

Merged

Conversation

barendgehrels
Copy link
Collaborator

This relatively small PR removes things and changes a few minor things.
It prepares the next PR which will change traversal.

@barendgehrels barendgehrels self-assigned this Jan 1, 2025
@barendgehrels barendgehrels force-pushed the refactor/remove-unused branch from 40f3c97 to 44602ef Compare January 1, 2025 22:23
@barendgehrels barendgehrels force-pushed the refactor/remove-unused branch 2 times, most recently from 07f419e to baf2da2 Compare January 1, 2025 22:38
Copy link
Collaborator

@tinko92 tinko92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (one note in in-line comment).

@barendgehrels barendgehrels force-pushed the refactor/remove-unused branch 2 times, most recently from b091257 to c0d13f8 Compare January 3, 2025 19:11
@barendgehrels barendgehrels force-pushed the refactor/remove-unused branch from c0d13f8 to 3589d5e Compare January 3, 2025 19:12
Copy link
Member

@vissarion vissarion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not deeply understand the code but to my understanding the changes are OK. Thanks!

@barendgehrels barendgehrels merged commit cda90e5 into boostorg:develop Jan 10, 2025
23 checks passed
@barendgehrels barendgehrels deleted the refactor/remove-unused branch January 10, 2025 17:43
@vissarion vissarion added this to the 1.88 milestone Mar 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants