New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Digest calculated in batches of sizeof(size_t) #606

Draft

grisumbras wants to merge 3 commits into boostorg:develop from grisumbras:batched-digest

Member

grisumbras commented Aug 8, 2021 •

edited

Loading

Fixes #601

grisumbras mentioned this pull request

Faster digest #601

Open

codecov bot commented Aug 8, 2021 •

edited

Loading

Codecov Report

Merging #606 (c291598) into develop (8957955) will decrease coverage by 0.05%.
The diff coverage is 80.76%.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop     #606      +/-   ##
===========================================
- Coverage    92.98%   92.94%   -0.05%     
===========================================
  Files           85       85              
  Lines         8058     8080      +22     
===========================================
+ Hits          7493     7510      +17     
- Misses         565      570       +5

Impacted Files	Coverage Δ
include/boost/json/detail/digest.hpp	`82.75% <80.76%> (-17.25%)`	⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8957955...c291598. Read the comment docs.

grisumbras force-pushed the batched-digest branch 2 times, most recently from f99afa3 to a97a76f Compare

August 8, 2021 14:39

cppalliance-bot commented Aug 8, 2021

Benchmark test results. More info at https://benchmark.cppalliance.org/jsonbenchmarks-pullrequests/606/pullrequest.html

Member

vinniefalco commented Oct 5, 2021

What is the status of this?

grisumbras force-pushed the batched-digest branch from a97a76f to ff55382 Compare

October 10, 2021 09:20

Member Author

grisumbras commented Oct 10, 2021

I've made 6 variants of this and benched them. Here are the results:
https://docs.google.com/spreadsheets/d/1WEfTLx5vEb5TduzzHt-OkAj6HnS4ku4Y4Y7C3YGIgc8/edit?usp=sharing
The 6th approach seems most promising, fairly small regression for a few tests and huge improvements for many tests. But my local benchmarking disagrees with CI as you can see on the picture posted above by the bot.

Member

vinniefalco commented Oct 10, 2021

yeah the automated performance CI bot is not accurate

cppalliance-bot commented Oct 10, 2021

Benchmark test results. More info at https://benchmark.cppalliance.org/jsonbenchmarks-pullrequests/606/pullrequest.html

Member

vinniefalco commented Oct 27, 2021

FYI this is still on my radar, but I have to wait until I return to boost.http_proto.

grisumbras force-pushed the batched-digest branch 2 times, most recently from cf0143c to 9d848ed Compare

June 15, 2023 14:04

cppalliance-bot commented Jun 15, 2023

Benchmark test results. More info at https://benchmark.cppalliance.org/jsonbenchmarks-pullrequests/606/pullrequest.html

grisumbras force-pushed the batched-digest branch from b308c19 to 4255529 Compare

June 15, 2023 17:11

cppalliance-bot commented Jun 15, 2023

Benchmark test results. More info at https://benchmark.cppalliance.org/jsonbenchmarks-pullrequests/606/pullrequest.html

grisumbras force-pushed the batched-digest branch 9 times, most recently from 0e823dc to e174db9 Compare

June 15, 2023 20:43

cppalliance-bot commented Jun 15, 2023

Benchmark test results. More info at https://benchmark.cppalliance.org/jsonbenchmarks-pullrequests/606/pullrequest.html

grisumbras force-pushed the batched-digest branch 4 times, most recently from 84d8b73 to 3f4f931 Compare

June 16, 2023 08:04

cppalliance-bot commented Jun 16, 2023

Benchmark test results. More info at https://benchmark.cppalliance.org/jsonbenchmarks-pullrequests/606/pullrequest.html

grisumbras force-pushed the batched-digest branch 12 times, most recently from 8ae0c09 to 12fcc52 Compare

June 16, 2023 13:13


          calculate digest in batches

4c98272

This is intended to increase performance

grisumbras force-pushed the batched-digest branch 2 times, most recently from 5baf791 to 632fea9 Compare

June 16, 2023 14:44


          temp

699a2e4

grisumbras force-pushed the batched-digest branch from 632fea9 to 699a2e4 Compare

June 16, 2023 14:53

cppalliance-bot commented Jun 16, 2023

Benchmark test results. More info at https://benchmark.cppalliance.org/jsonbenchmarks-pullrequests/606/pullrequest.html


          temp2

c291598

cppalliance-bot commented Jun 19, 2023

Benchmark test results. More info at https://benchmark.cppalliance.org/jsonbenchmarks-pullrequests/606/pullrequest.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment