Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecated-dynamic-exception-spec warning #112

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

jonesmz
Copy link

@jonesmz jonesmz commented Jul 14, 2021

No description provided.

@vprus
Copy link
Collaborator

vprus commented Jul 15, 2021

Thanks for the PR?
Would it change the C++ level the library requires, though? I think it still compiles without C++ 11.

@jonesmz
Copy link
Author

jonesmz commented Jul 15, 2021

noexcept keyword was introduced in C++11.

noexcept is not 100% identical to throw(), but for the way boost program options uses it, they are equivalent.

Someone could define a BOOST_PROGRAM_OPTIONS_NOTHROW macro, which would use either throw() or noexcept based on the C++ language version detected at compile time.

Just to be clear, I don't intend to revisit this PR, or add support for older versions of C++ earlier than C++11. It's not that I think that's a bad idea, it's just beyond the scope of the time I have available for this work.

Someone else can add new commits to this PR, or this PR can be closed and replaced with a different PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants