Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix long case insensitive and short case sensitive combo. #75

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

Landberg
Copy link

@Landberg Landberg commented Feb 7, 2019

The local_option update for the short_name match was removed in v1.68.0, but it is needed to allow for case insensitive long names combined with case sensitive short names. See #74 for more info about the problem.

The local_option update for the short_name match was removed in v1.68.0, but it is needed to allow for case insensitive long names combined with case sensitive short names.  See boostorg#74 for more info about the problem.
@codecov
Copy link

codecov bot commented Feb 7, 2019

Codecov Report

Merging #75 into develop will increase coverage by 0.03%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #75      +/-   ##
===========================================
+ Coverage    49.89%   49.92%   +0.03%     
===========================================
  Files           23       23              
  Lines         1385     1386       +1     
  Branches       707      708       +1     
===========================================
+ Hits           691      692       +1     
  Misses         110      110              
  Partials       584      584
Impacted Files Coverage Δ
src/options_description.cpp 48.46% <0%> (-0.19%) ⬇️
...de/boost/program_options/detail/value_semantic.hpp 43.75% <0%> (+1.56%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d95d316...3ee744c. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant