fix #232 #234
Merged
fix #232 #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jzmaddock
reviewed
Nov 27, 2024
| #else | ||
| throw e; | ||
| #endif | ||
| BOOST_REGEX_DETAIL_THROW("Invalid regular expression object"); |
There was a problem hiding this comment.
Ideally this should still throw a std::invalid_argument, otherwise we're breaking the interface?
|
Apart from my tiny comment above, this all looks good to me: thanks Christian! |
Credit to OSS-Fuzz for finding the problematic test regexes and configurations.
cmazakas
force-pushed
the
feature/fix-232
branch
from
901aaaf to
dbbd7c9
Compare
We might as well get this in and then add that later? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wasn't exactly sure how to organize the tests or how much I should cover.
If you'd like, @jzmaddock , I can close this PR and I can instead open a new one with much more comprehensive test coverage for the match flags a user can pass in.