Enable BOOST_STL_INTERFACES_USE_DEDUCED_THIS on Clang 19 and MSVC 19.41 #68
Conversation
There was a problem hiding this comment.
I don't want to have two different macros one called DO_IT and one called DONT_DO_IT. What are the intended semantics when they say different things?
Moreover, this is not the way this is done in Boost. If there is a specific version after which language support is available, then we should check for that specific range or versions. Could you update this so that it automatically detects the MSVC verions in question with defined(__cpp_explicit_this_parameter) || YOUR_THING_HERE?
|
@ednolan Ping. The deadline approaches. :) Could you make the requested changes? |
Clang 19 and MSVC 19.41 both have support for deducing this that is complete enough to allow the v3 version of this library to work but not complete enough for the compilers to define __cpp_explicit_this_parameter. This commit enables the v3 version of this library on compilers with that version or newer. We make use of BOOST_CLANG_VERSION here because on AppleClang it should provide the version of upstream Clang that was used for that release.
ednolan
force-pushed
the
enolan_enablemacros1
branch
from
dd5baec to
93d9220
Compare
ednolan
changed the title
|
I made the requested changes, let me know if the most recent commit is good. I've verified that utf_view CI passes with it on both MSVC and Clang: https://github.com/ednolan/utf_view/actions/runs/11492656840 |
|
Thanks! It will be in the next Boost release. |
Clang 19 and MSVC 17.11.35222.181 both have support for deducing this that is complete enough to allow the v3 version of this library to work but not complete enough for the compilers to define __cpp_explicit_this_parameter. By adding
BOOST_STL_INTERFACES_ENABLE_DEDUCED_THIS, users of those compilers can explicitly opt into the v3 interface even when their compilers do not advertise support for deducing this.
BOOST_STL_INTERFACES_ENABLE_CONCEPTS is added for symmetry.