ephemeral: Add an option to override the entrypoint #149
Conversation
The goal is to make it easier to debug entrypoint failures as one can do e.g. ``` $ bcvk ephemeral run -ti --debug-entrypoint bash -K --name mytestvm2 quay.io/fedora/fedora-bootc:42 ``` (And also e.g. interactively inspect the state of the container before bwrap and qemu is launched etc.) Signed-off-by: Colin Walters <[email protected]>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a --debug-entrypoint option to ephemeral run and ephemeral run-ssh commands, allowing users to override the default container entrypoint for debugging purposes. The implementation is straightforward and correctly applies the override when the option is provided. The changes also include updates to documentation.
My review includes one suggestion to improve the documentation for bcvk-ephemeral-run-ssh to clarify the expected behavior when using this new debug flag, which will prevent user confusion.
|
|
||
| **--debug-entrypoint**=*DEBUG_ENTRYPOINT* | ||
|
|
||
| Do not run the default entrypoint directly, but instead invoke the provided command (e.g. `bash`) |
There was a problem hiding this comment.
It would be helpful to add a note here explaining that using --debug-entrypoint with run-ssh will cause the command to time out waiting for SSH. This is because this option prevents the VM from starting, so SSH will never become available. This will help users understand the expected behavior when using this debug flag.
| Do not run the default entrypoint directly, but instead invoke the provided command (e.g. `bash`) | |
| Do not run the default entrypoint directly, but instead invoke the provided command (e.g. `bash`). Note that using this option will prevent the VM from starting, and the `run-ssh` command will time out waiting for a connection. |
1 participant
The goal is to make it easier to debug entrypoint failures as one can do e.g.
(And also e.g. interactively inspect the state of the container before
bwrap and qemu is launched etc.)