virtiofsd_paths: Extends virtiofsd binary locations #163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit extends the list of virtiofsd binary locations. This change enables running a bootc container as an ephemeral VM on Arch Linux, as the Arch package installs the virtiofsd binary in /usr/lib/virtiofsd. Signed-off-by: Matteo Piccinini (loacker) <[email protected]>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request correctly extends the search paths for the virtiofsd binary to include the location used on Arch Linux, fixing the reported issue. My review includes a suggestion to make this binary discovery more robust by searching the system's PATH first, which would improve compatibility with other Linux distributions without future code changes.
cgwalters
approved these changes
Nov 25, 2025
Collaborator
cgwalters
left a comment
cgwalters
left a comment
There was a problem hiding this comment.
Thanks, looks sane to me!
One thing this intersects with a bit is #124 - we could try extending our test suite for different host OSes by running them as a container. That one needs a bit of work.
Another approach I've been thinking about is to try always doing libvirt-in-container for ephemeral.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit extends the list of virtiofsd binary locations. This change enables running a bootc container as an ephemeral VM on Arch Linux, as the Arch package installs the virtiofsd binary in /usr/lib/virtiofsd.
bcvk is crashing because it cannot locate the virtiofsd binary.
The virtiofsd package files are listed here. On Arch Linux, the virtiofsd binary is found at /usr/lib/virtiofsd.
I implemented a temporary workaround by creating a symlink to /usr/local/bin/virtiofsd.