ephemeral: Two debug improvement patches #95
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces two significant debugging improvements for ephemeral VMs. First, it adds the ability to redirect virtiofsd output to log files within the container, which is now enabled by default for all mounts. Second, it sets up a systemd service within the guest VM to stream the system journal via a virtio-serial device to a log file in the container. The changes also include documentation for these new debugging features.
My review focuses on improving the asynchronous code quality. I've pointed out a couple of places where synchronous file I/O operations are used within async functions, which can block the executor thread. I've provided suggestions to use the asynchronous equivalents from tokio.
cgwalters
force-pushed
the
ephemeral-debugging
branch
2 times, most recently
from
8d7ad6d to
a5038fa
Compare
Add support for logging virtiofsd output to help diagnose filesystem sharing issues between the container and VM. Assisted-By: Claude Code (Sonnet 4.5) Signed-off-by: Colin Walters <[email protected]>
Automatically stream the guest VM's systemd journal to the host for easier debugging of boot failures and systemd service issues. Assisted-By: Claude Code (Sonnet 4.5) Signed-off-by: Colin Walters <[email protected]>
cgwalters
force-pushed
the
ephemeral-debugging
branch
from
a5038fa to
5c6aae1
Compare
2 participants
No description provided.