tests: consolidate libvirt karg testing to reduce base disk creation #96
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the dedicated test_libvirt_run_ssh_full_workflow test and fold kernel argument testing into test_libvirt_run_bind_mounts instead. The separate test was creating a unique base disk just to validate --karg functionality, taking 8-10 minutes in CI. In a fresh CI environment, each test with different parameters (image, filesystem, or kernel args) triggers a separate base disk creation via bootc install. The removed test used --karg bcvk.test-install-karg=1, which created a unique cache key and prevented sharing with other tests. By consolidating karg validation into an existing test that already boots a VM and uses SSH, we eliminate one redundant base disk creation while maintaining the same test coverage. This change reduces the libvirt_verb test suite from 7 to 6 VM-creating tests, with 5 tests now sharing a single base disk (fedora-bootc:42 + ext4 + no kargs) and only the bind_mounts test requiring its own base disk due to the test karg. Assisted-by: Claude Code (Sonnet 4.5) Signed-off-by: Colin Walters <[email protected]>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request effectively consolidates kernel argument testing to optimize CI performance by reducing redundant base disk creation. The changes are logical and correctly implemented, moving the test logic from a dedicated test into an existing one, which is a great improvement. I have one suggestion to improve maintainability by using a constant for the kernel argument string, which is currently duplicated.
jeckersb
approved these changes
Oct 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the dedicated test_libvirt_run_ssh_full_workflow test and fold kernel argument testing into test_libvirt_run_bind_mounts instead. The separate test was creating a unique base disk just to validate --karg functionality, taking 8-10 minutes in CI.
In a fresh CI environment, each test with different parameters (image, filesystem, or kernel args) triggers a separate base disk creation via bootc install. The removed test used --karg bcvk.test-install-karg=1, which created a unique cache key and prevented sharing with other tests.
By consolidating karg validation into an existing test that already boots a VM and uses SSH, we eliminate one redundant base disk creation while maintaining the same test coverage.
This change reduces the libvirt_verb test suite from 7 to 6 VM-creating tests, with 5 tests now sharing a single base disk (fedora-bootc:42 + ext4 + no kargs) and only the bind_mounts test requiring its own base disk due to the test karg.
Assisted-by: Claude Code (Sonnet 4.5)