- 
                Notifications
    You must be signed in to change notification settings 
- Fork 144
Prep for multiple container image stores #695
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| Rough draft of how I envision this might work.  One notable thing is that this version does not use async at all, however I expect that will probably become necessary when we add future backends (it started to creep in over in #215).  Things were starting to get unwieldy here with async because of things like  | 
0c57786    to
    5bbc98d      
    Compare
  
    | Notable changes since last version: 
 | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks sane to me!
For now, this is effectively a no-op as it only implements a store for the current ostree container implementation. Beyond some minor code movement and plumbing, this also only handles the store implementation backing the `bootc status` command. Additional image store functionality (check, pull, delete, etc.) will be added in future changes in order to keep things smaller and more manageable. Signed-off-by: John Eckersberg <[email protected]>
| Ok, rebased, added the alias, and added a test. | 
…5.13 build(deps): bump clap from 4.5.11 to 4.5.13
For now, this is effectively a no-op as it only implements a store for
the current ostree container implementation.
Beyond some minor code movement and plumbing, this also only handles
the store implementation backing the
bootc statuscommand.Additional image store functionality (check, pull, delete, etc.) will
be added in future changes in order to keep things smaller and more
manageable.