Fix recent caching issues #407
Open
+6
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cache-control: max-age=3600 will force browsers to cache static files for one hour. This commit also enables headers module that allows adding HTTP headers from apache.
Due to missing cache-control headers, some browsers might have picked a long caching time based on heuristics. This commits forces browsers to refresh messages cache.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a caching header for static files. The header should force browser to cache static files for one hour.
After a cached file expires, browser usually revalidate it by making a conditional request (If-None-Match, If-Modified-Since). It seems that Apache does support conditional requests - a simple test can be done by reducing the caching time to 10 seconds and browsing Elixir for a while. After every 10 second period, first request to each static file gets a 304, unless the file was modified on the disk.
The PR also adds ?v to messages URL, and increments ?v on script.js to make sure that browser refresh the messages file.