Ambarella upstream #73
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,51 @@ | ||
| # Ambarella CV22 recovery configuration | ||
|
|
||
| # Device identification | ||
| vid: 0x1b8e # Ambarella vendor ID | ||
| pid: 0xc022 # CV22 product ID | ||
phodina marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| # Recovery protocol | ||
| protocol: amba | ||
|
There was a problem hiding this comment. this is information about some internal details of the snagrecover code, it shouldn't be included in the user interface. |
||
|
|
||
| # Required firmware files | ||
| firmware: | ||
| # DRAM initialization script | ||
| dram_script: | ||
| path: cv22_lpddr4_408MHz.ads | ||
| description: DRAM initialization script for CV22 LPDDR4 at 408MHz | ||
|
There was a problem hiding this comment. It's nice to have a description here, but it's also repetitive, as this information is already given in the fw_binaries docs. I don't have a definitive opinion about this yet. |
||
|
|
||
| # Bootloader binary | ||
| bootloader: | ||
| path: cv22_bld_linux_emmc.bin | ||
| description: CV22 bootloader for Linux eMMC boot | ||
|
|
||
| # Recovery steps | ||
| steps: | ||
| - name: Initialize DRAM | ||
|
There was a problem hiding this comment. The problem with this is that it's documentation for how snagrecover works internally. So if the recovery process or the nomenclature evolves at some point, we'll have to keep this template up to date as well. Moreover, the user ideally shouldn't have to worry about these details. |
||
| action: initialize_dram | ||
| description: Initialize device DRAM using ADS script | ||
|
|
||
| - name: Load bootloader | ||
| action: load_bootloader | ||
| description: Load bootloader to device memory | ||
|
|
||
| - name: Flash firmware | ||
| action: flash_firmware | ||
| description: Flash firmware image to device | ||
| args: | ||
| firmware: firmware.bin # Firmware image to flash | ||
|
|
||
| # Recovery flow description | ||
| description: | | ||
| Recovery process for Ambarella CV22 devices: | ||
| 1. Device enters USB recovery mode | ||
| 2. Initialize DRAM using ADS script | ||
| 3. Load bootloader to memory | ||
| 4. Flash firmware image | ||
| 5. Device boots from flashed firmware | ||
|
|
||
| # Additional notes | ||
| notes: | | ||
| - Ensure device is in USB recovery mode before starting | ||
phodina marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| - DRAM script and bootloader files must be in firmware directory | ||
| - Firmware image should be compatible with CV22 | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is very different from what any of the current template files look like.
I'm not against improvements to the template file format, but I don't want them mixed in with this SoC support series.
I've made a few comments below in case you want to submit a future series to make these improvements, but please don't include them in this series. For now, you should just include your
firmwaresection and leave out the rest.