blake2b_256: fix key passing, fixes #8867 #8887
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8887 +/- ##
==========================================
+ Coverage 81.43% 81.46% +0.02%
==========================================
Files 77 77
Lines 13515 13530 +15
Branches 2004 2004
==========================================
+ Hits 11006 11022 +16
Misses 1853 1853
+ Partials 656 655 -1 ☔ View full report in Codecov by Sentry. |
ThomasWaldmann
force-pushed
the
fix-blake2b-key
branch
2 times, most recently
from
ccf8455 to
3ec10c5
Compare
borg 1.x involved the key a bit unusually in the blake2b hash calculation (padding 64B of key material with another 64B of zeros to a total of 128B and then just prepending it to the data). since a while, we use blake2b from python stdlib and they support passing the key as a separate argument. up to 64B keys are allowed here. besides the way how the 64B of key material are passed, there are also other differences in how the key gets involved in the digest computation, thus the legacy blake2b hashes from borg 1.x are not compatible with the non-legacy ones - the hash is not the same for same key and data values.
ThomasWaldmann
force-pushed
the
fix-blake2b-key
branch
from
3ec10c5 to
8e85f90
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
borg 1.x involved the key a bit unusually in the blake2b hash calculation (padding 64B of key material with another 64B of zeros to a total of 128B and then just prepending it to the data).
since a while, we use blake2b from python stdlib and they support passing the key as a separate argument. up to 64B keys are allowed here.
besides the way how the 64B of key material are passed, there are also other differences in how the key gets involved in the digest computation, thus the legacy blake2b hashes from borg 1.x are not compatible with the ones borg 2 will use. The hash is not the same for same key and data values.