Skip to content

Upgrade ruff, fix issues, use ruff for import sorting#3380

Closed
akx wants to merge 5 commits intoboto:developfrom
akx:upruff
Closed

Upgrade ruff, fix issues, use ruff for import sorting#3380
akx wants to merge 5 commits intoboto:developfrom
akx:upruff

Conversation

@akx
Copy link
Copy Markdown
Contributor

@akx akx commented Feb 7, 2025

This PR:

  • upgrades the version of Ruff used from 0.4.8 to 0.9.4
  • copies the exclude rules from pre-commit configuration to the Ruff configuration, to make it possible to run ruff outside of pre-commit
  • reapplies ruff format (mechanical)
  • fixes other new complaints surfaced by the new version of Ruff
  • gets rid of isort for import sorting in favor of just ruff's I rule.
    • This had some manual work go into it, to keep the context of the noqa comments intact.

@akx akx force-pushed the upruff branch 2 times, most recently from 5bd03ed to 970dc0e Compare February 7, 2025 06:52
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Feb 7, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (develop@976b894). Learn more about missing BASE report.
⚠️ Report is 1389 commits behind head on develop.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #3380   +/-   ##
==========================================
  Coverage           ?   93.03%           
==========================================
  Files              ?       66           
  Lines              ?    14452           
  Branches           ?        0           
==========================================
  Hits               ?    13446           
  Misses             ?     1006           
  Partials           ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@akx
Copy link
Copy Markdown
Contributor Author

akx commented Jul 22, 2025

Well, looks like @nateprewitt did this work some 4 months later in #3495 😄

@akx akx closed this Jul 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants