Fix corrupted S3 downloads when file object in append mode #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swt2c
reviewed
Dec 4, 2018
| @@ -24,7 +24,7 @@ | |||
| ReadTimeoutError | |||
|
|
|||
| from s3transfer.compat import SOCKET_ERROR | |||
| from s3transfer.compat import seekable | |||
| from s3transfer.compat import seekable, writes_are_seekable | |||
There was a problem hiding this comment.
Just a fly-by comment here, but unless I'm missing something, you don't actually call this writes_are_seekable() function anywhere, so how does this fix the problem?
There was a problem hiding this comment.
Excellent that someone is awake, added the missing call from my staging 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The DownloadSeekableOutputManager with threading causes file corruption when the output file is opened in append mode.
The file object is still seekable, but only for reads, the writes will be written into the end of the file.
This is also the root cause for boto/boto3#1446, and fixes the issue.