Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support file-like objects in CRT transfer manager #279

Merged
merged 1 commit into from
Nov 3, 2023

Conversation

kyleknap
Copy link
Contributor

@kyleknap kyleknap commented Nov 2, 2023

This is a backport of this pull request: aws/aws-cli#8291, which was implemented based off this pull request: #277. Also note that the integration tests do not pass using the current version of CRT that is pinned in botocore. They do however pass if you update to the latest version of awscrt. I don't think that should block merging this PR as it will be merged into a feature branch. However, we will need to update the awscrt pin in botocore before merging the feature branch.

)
credetial_resolver = self.session.get_component('credential_provider')
self.s3_crt_client = s3transfer.crt.create_s3_crt_client(
self.session.get_config_variable("region"), credetial_resolver
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this will pull in a fix that we made in v2 where we were using the session's region. However, we never directly set the region on the session even though we set the region to be us-west-2 for the base test class.

Copy link
Contributor

@nateprewitt nateprewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kyleknap kyleknap merged commit b8906b3 into boto:crt-enhancements Nov 3, 2023
13 checks passed
@kyleknap kyleknap deleted the crt-streams branch November 3, 2023 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants