Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scope awscrt.s3 imports to functions #293

Merged
merged 1 commit into from
Nov 29, 2023
Merged

Scope awscrt.s3 imports to functions #293

merged 1 commit into from
Nov 29, 2023

Conversation

nateprewitt
Copy link
Contributor

Defer CRT import references until used in a function for cases where an unexpected CRT version exists in the environment.

@codecov-commenter
Copy link

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (67a91d5) 83.06% compared to head (e7fd092) 83.03%.
Report is 1 commits behind head on develop.

Files Patch % Lines
s3transfer/crt.py 0.00% 4 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop     #293      +/-   ##
===========================================
- Coverage    83.06%   83.03%   -0.03%     
===========================================
  Files           16       16              
  Lines         2810     2811       +1     
===========================================
  Hits          2334     2334              
- Misses         476      477       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nateprewitt nateprewitt merged commit edbc334 into develop Nov 29, 2023
28 checks passed
@nateprewitt nateprewitt deleted the crt_imports branch November 29, 2023 19:26
aws-sdk-python-automation added a commit that referenced this pull request Nov 29, 2023
@aws-sdk-python-automation
Merge branch 'release-0.8.2'
8a32c1f 
* release-0.8.2:
  Bumping version to 0.8.2
  Scope awscrt.s3 imports to functions (#293)
  Add changelog for subscribers cache (#292)
  Use lru_cache on costly validation function. (#291)
@nateprewitt nateprewitt mentioned this pull request Dec 19, 2023
Closed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyleknap kyleknap kyleknap approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nateprewitt @codecov-commenter @kyleknap