Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruff update #308

Merged
merged 5 commits into from
Jul 22, 2024
Merged

Ruff update #308

merged 5 commits into from
Jul 22, 2024

Conversation

nateprewitt
Copy link
Contributor

This is a follow up to boto/boto3#4161 to move our repos to use ruff in favor of our existing pre-commit cocktail.

This should be largely inline with our existing configuration with some minor changes to fix f-string upgrades missed with our previous setup and some newline fixes. This PR keeps our existing quote preservation behavior until we get all projects moved to ruff. At that point, we can look at turning it to "double".

@codecov-commenter
Copy link

codecov-commenter commented Jun 21, 2024

Codecov Report

Attention: Patch coverage is 90.90909% with 1 line in your changes missing coverage. Please review.

Project coverage is 82.44%. Comparing base (123ff16) to head (a414253).
Report is 4 commits behind head on develop.

Files Patch % Lines
s3transfer/futures.py 50.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #308      +/-   ##
===========================================
- Coverage    83.08%   82.44%   -0.65%     
===========================================
  Files           16       16              
  Lines         2814     2836      +22     
===========================================
  Hits          2338     2338              
- Misses         476      498      +22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nateprewitt nateprewitt marked this pull request as ready for review July 22, 2024 20:42
@nateprewitt nateprewitt merged commit 97f26df into develop Jul 22, 2024
76 checks passed
@nateprewitt nateprewitt deleted the ruff branch July 22, 2024 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants