Pass operation name to awscrt.s3 #309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nateprewitt
reviewed
Jun 21, 2024
nateprewitt
approved these changes
Jun 21, 2024
aws-sdk-python-automation
added a commit
that referenced
this pull request
Jun 24, 2024
* release-0.10.2: Bumping version to 0.10.2 Pass operation name to awscrt.s3 (#309) CRTTransferManager validates ExtraArgs and Bucket, same as classic TransferManager (#294) Start testing on 3.13 beta build Move 3.8 and 3.9 builds back to macos-13 update wheel to latest release (#303) Upgrade pytest and associated test packages (#302)
hswong3i
pushed a commit
to alvistack/boto-s3transfer
that referenced
this pull request
Jun 25, 2024
--------- Co-authored-by: Nate Prewitt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
awscrt.s3will soon require thatoperation_namebe passed forS3RequestType.DEFAULT(see: awslabs/aws-c-s3#439, awslabs/aws-crt-python#574)Only
CRTTransferManager.delete()usesS3RequestType.DEFAULT. Fix it to pass alongoperation_name="DeleteObject"