Returns client response from upload_file #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I really want this. Thanks for fix it |
|
@aweidner I'm interested on this to be reviewed by upstream too. Would you mind to tag the issue with the label "needs-review" to bring better visibility over it? |
|
@ricbartm Seems only those with write access to the repository are allowed to apply a label to a pull request. I'd love to get this reviewed if possible though, it has been open for a while now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #82
The only thing I'm not sure of here is the testing. I'm not a fan of having multiple assert statements in the same test cases but I don't want to duplicate the existing test code unnecessarily. Thoughts?