Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keep track of original attr name #52

Merged
merged 1 commit into from
Nov 18, 2023
Merged

keep track of original attr name #52

merged 1 commit into from
Nov 18, 2023

Conversation

withinboredom
Copy link
Contributor

When a parameter to render() is not lower cased, parameters aren't passed from attributes. A good example:

echo "<Login redirectTo='{{$host}}' />";

would result in trying to call render($redirectto) {} instead of render($redirectTo) {}.

This actually opens up an obvious optimization, but that is out of scope here.

Copy link

codecov bot commented Nov 18, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (b4d3c68) 32.43% compared to head (9742bbf) 32.52%.

Files Patch % Lines
src/Template/Parser/StreamingCompiler.php 60.00% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main      #52      +/-   ##
============================================
+ Coverage     32.43%   32.52%   +0.09%     
  Complexity      538      538              
============================================
  Files            52       51       -1     
  Lines          1819     1823       +4     
============================================
+ Hits            590      593       +3     
- Misses         1229     1230       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@withinboredom withinboredom added this pull request to the merge queue Nov 18, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to Branch Protection failures Nov 18, 2023
You're not authorized to push to this branch. Visit "About protected branches" for more information.
@withinboredom withinboredom added this pull request to the merge queue Nov 18, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to Branch Protection failures Nov 18, 2023
You're not authorized to push to this branch. Visit "About protected branches" for more information.
@withinboredom withinboredom merged commit ffed1e0 into main Nov 18, 2023
5 checks passed
@withinboredom withinboredom deleted the fix/names branch November 18, 2023 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant