Add caching #56
Merged
Add caching #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+63
to
+87
| public function with( | ||
| int|null|false $maxAge = false, | ||
| int|null|false $sMaxAge = false, | ||
| bool|null $noCache = null, | ||
| bool|null $mustRevalidate = null, | ||
| bool|null $proxyRevalidate = null, | ||
| bool|null $noStore = null, | ||
| bool|null $public = null, | ||
| bool|null $immutable = null, | ||
| int|null|false $staleWhileRevalidating = false, | ||
| int|null|false $staleIfError = false, | ||
| ): self { | ||
| return new self( | ||
| maxAge: $this->withInt($this->maxAge, $maxAge), | ||
| sMaxAge: $this->withInt($this->sMaxAge, $sMaxAge), | ||
| noCache: $this->withBool($this->noCache, $noCache), | ||
| mustRevalidate: $this->withBool($this->mustRevalidate, $mustRevalidate), | ||
| proxyRevalidate: $this->withBool($this->proxyRevalidate, $proxyRevalidate), | ||
| noStore: $this->withBool($this->noStore, $noStore), | ||
| public: $this->withBool($this->public, $public), | ||
| immutable: $this->withBool($this->immutable, $immutable), | ||
| staleWhileRevalidating: $this->withInt($this->staleWhileRevalidating, $staleWhileRevalidating), | ||
| staleIfError: $this->withInt($this->staleIfError, $staleIfError), | ||
| ); | ||
| } |
Check warning
Code scanning / PHPMD
Code Size Rules: ExcessiveParameterList Warning
withinboredom
force-pushed
the
add-caching
branch
from
2acfe2f
to
92ea447
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #56 +/- ##
============================================
+ Coverage 32.52% 37.44% +4.91%
- Complexity 538 570 +32
============================================
Files 51 50 -1
Lines 1823 1888 +65
============================================
+ Hits 593 707 +114
+ Misses 1230 1181 -49 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #39
This adds some attributes for caching per component where the "highest score wins" type of algorithm. Basically private > public, max-age < no-cache < must-revalidate, etc.