Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cache: handle private separately #58

Merged
merged 1 commit into from
Dec 31, 2023
Merged

cache: handle private separately #58

merged 1 commit into from
Dec 31, 2023

Conversation

withinboredom
Copy link
Contributor

Don't send just a Cache-Control: public header if caching isn't configured.

Copy link

codecov bot commented Dec 31, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8f8a352) 37.44% compared to head (52df376) 37.54%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main      #58      +/-   ##
============================================
+ Coverage     37.44%   37.54%   +0.09%     
+ Complexity      570      569       -1     
============================================
  Files            50       50              
  Lines          1888     1891       +3     
============================================
+ Hits            707      710       +3     
  Misses         1181     1181              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@withinboredom withinboredom merged commit 400533c into main Dec 31, 2023
5 checks passed
@withinboredom withinboredom deleted the fix/caching branch December 31, 2023 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant