generated from amazon-archives/__template_MIT-0
-
Notifications
You must be signed in to change notification settings - Fork 25
Add multiple k8s settings #104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+94
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2ca672a to
efda8b9
Compare
efda8b9 to
01d6475
Compare
|
^ Force push removes my commit adding imageMaximumGCAge (since that's handled by #87) and adds a commit for the 0.17.0 release |
piyush-jena
reviewed
Oct 9, 2025
|
@koooosh Thank you for working on this! @piyush-jena Is this still in time to be released with v1.50 ? |
ytsssun
approved these changes
Oct 23, 2025
arnaldo2792
reviewed
Oct 23, 2025
arnaldo2792
reviewed
Oct 23, 2025
Signed-off-by: Kush Upadhyay <[email protected]>
Signed-off-by: Kush Upadhyay <[email protected]>
Signed-off-by: Kush Upadhyay <[email protected]>
Signed-off-by: Kush Upadhyay <[email protected]>
Signed-off-by: Kush Upadhyay <[email protected]>
Signed-off-by: Kush Upadhyay <[email protected]>
01d6475 to
7433399
Compare
|
Force push addresses above minor comments + includes commit adding new Beta options for |
ytsssun
approved these changes
Nov 5, 2025
piyush-jena
approved these changes
Nov 5, 2025
arnaldo2792
approved these changes
Nov 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
bottlerocket-os/bottlerocket#4058
bottlerocket-os/bottlerocket#4544
bottlerocket-os/bottlerocket#4643
bottlerocket-os/bottlerocket#4675
Description of changes:
Add the following k8s settings:
KubernetesIdsPerPodValueto enforce constraints + resultingmodeled-typesversion bumpcpu-manager-policy-optionsAlso, bumping
settings-modelsversion to 0.17.0 + updating changelog for new release.Testing Description:
Note: This also tests the imageMinimumGCAge and imageMaximumGCAge settings added in #87
cargo testImageMaximumGCAgefeature gate) and created a nodegroup with it and the following userdata:idsPerPod) and created a nodegroup with it and the following userdata:Beta options testing
prefer-align-cpus-by-uncorecacheanddistribute-cpus-across-numaoptions cannot be used together, so verified this works for both combinationsBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.