fix: align kubernetes cluster name validation with EKS #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcressey
approved these changes
Nov 12, 2024
arnaldo2792
approved these changes
Nov 12, 2024
cartermckinnon
force-pushed
the
develop
branch
from
7b43ed9
to
2b2ebb5
Compare
cartermckinnon
changed the title
|
Fixed the commitlint check, but the build is failing with a bunch of license errors that don't seem related? https://github.com/bottlerocket-os/bottlerocket-settings-sdk/actions/runs/11803486817/job/32882468268 |
bcressey
approved these changes
Nov 12, 2024
|
Ah, I noticed when testing this commit locally that the tests failed, so I ended up pushing my |
cartermckinnon
force-pushed
the
develop
branch
from
439d0ca
to
df94b48
Compare
cartermckinnon
commented
Nov 13, 2024
| @@ -353,14 +358,14 @@ mod test_kubernetes_cluster_name { | |||
|
|
|||
| #[test] | |||
| fn good_cluster_names() { | |||
| for ok in &["more-chars_here.now", &"a".repeat(63)] { | |||
| for ok in &["more-chars_here-123", &"a".repeat(100)] { | |||
There was a problem hiding this comment.
. no longer being an allowed character is the only notable change in this PR, I think
bcressey
approved these changes
Nov 13, 2024
| @@ -353,14 +358,14 @@ mod test_kubernetes_cluster_name { | |||
|
|
|||
| #[test] | |||
| fn good_cluster_names() { | |||
| for ok in &["more-chars_here.now", &"a".repeat(63)] { | |||
| for ok in &["more-chars_here-123", &"a".repeat(100)] { | |||
There was a problem hiding this comment.
nit: maybe a couple more test cases since we now allow trailing dashes and underscores:
Suggested change
| for ok in &["more-chars_here-123", &"a".repeat(100)] { | |
| for ok in &["more-chars_here-123", "trailing-dash-", "under_score_", &"a".repeat(100)] { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
This updates the
KubernetesClusterNamevalidation to align with EKS, per theeks:CreateClusterdocs: https://docs.aws.amazon.com/eks/latest/APIReference/API_CreateCluster.html#API_CreateCluster_RequestSyntaxBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.