Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for bootstrap commands #4131

Merged
merged 2 commits into from
Sep 4, 2024

Conversation

piyush-jena
Copy link
Contributor

Issue number:

Closes #

Description of changes:

  • Added migrations for bootstrap command settings

Testing done:

  • End to end testing with my copy of core-kit and settings-sdk for bootstrap commands feature

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

@piyush-jena piyush-jena marked this pull request as draft August 7, 2024 19:47
@ytsssun
Copy link
Contributor

ytsssun commented Aug 7, 2024

CI failed with

echo Found unformatted source files listed above. First-party source code is checked with gofmt and rustfmt.

Can you format your code?

Twoliter.lock Outdated Show resolved Hide resolved
sources/Cargo.toml Outdated Show resolved Hide resolved
sources/api/schnauzer/src/helpers.rs Outdated Show resolved Hide resolved
sources/api/schnauzer/src/helpers.rs Outdated Show resolved Hide resolved
sources/api/schnauzer/src/helpers.rs Outdated Show resolved Hide resolved
sources/api/schnauzer/src/helpers.rs Outdated Show resolved Hide resolved
sources/api/schnauzer/src/helpers.rs Outdated Show resolved Hide resolved
@piyush-jena piyush-jena force-pushed the develop branch 5 times, most recently from 6c4fc5a to 2a6f28e Compare August 9, 2024 21:49
@piyush-jena
Copy link
Contributor Author

Forced push resolves the following:

  1. Fixes merge conflicts
  2. Separates out commits for schnauzer and migration changes
  3. Fixes migrations

Copy link
Contributor

@bcressey bcressey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just need the final commits after the settings SDK release.

Copy link
Contributor

@yeazelm yeazelm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants