Ali sonmez/frontend/mark as complete

[sonwezali]

fetch task volunteers and add completion logic

[aahmeterenasl]

This logic appears to have a flaw. The canMarkAsComplete variable will evaluate to false when acceptedVolunteersCount > 0 but less than the required number of volunteers. This is because the request.status remains "POSTED" until the required number of volunteers is met.

[sonwezali]

You are definitely right. However, I think the problem is not related to this implementation but to the backend. In app/backend/core/models/task.py, we should update the logic of making a request "ASSIGNED" from the "POSTED" state as follows:

# Current logic:
  if current_assignee_count < self.volunteer_number:
      if self.status == TaskStatus.ASSIGNED:
          self.status = TaskStatus.POSTED
          self.save()
          return True
  elif current_assignee_count >= self.volunteer_number:
      if self.status == TaskStatus.POSTED:
          self.status = TaskStatus.ASSIGNED
          self.save()
          return True

  # New logic:
  if current_assignee_count < 1:
      if self.status == TaskStatus.ASSIGNED:
          self.status = TaskStatus.POSTED
          self.save()
          return True
  elif current_assignee_count >= 1:
      if self.status == TaskStatus.POSTED:
          self.status = TaskStatus.ASSIGNED
          self.save()
          return True

Let me know what you think.

[sonwezali]

I would like to here from you friends.

@aahmeterenasl @erayyuklu @akcayyusufkaan @erdkocak