Fix minor HYPRE and ADIOS2 compilation issues #3022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Caused linking issues. Also put used function in an anonymous namespace to prevent future linking issues
Also default to off
Usually installed under `usr/include/hypre` (or similar) for system packages
|
Hmm, more problems with 3D metrics and the Hypre laplacians. Guess I'll have to build that config locally to fix them all. |
|
It would be great to fix that, but I think disabling hypre with 3D is also fine. Hypre is often used - but only via PETSc, so that should be fine ... So adding a configure time error should be fine ... |
|
I think it's mostly just making some types |
|
I have it fixed, so that it compiles. |
|
Fixes #2701 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out we're not building HYPRE on CI at all, and we're silently not actually using ADIOS2, and that's let a couple of compilation issues creep in.
This fixes the compilation and CI issues (hopefully).