Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add i18n ADR #1794

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add i18n ADR #1794

wants to merge 2 commits into from

Conversation

pylipp
Copy link
Contributor

@pylipp pylipp commented Nov 26, 2024

@pylipp pylipp requested a review from aerinsol November 27, 2024 07:33
Copy link
Member

@aerinsol aerinsol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Might be worth revisiting TMS from a non-developer POV. Would integrating with a TMS add time to the dev estimate @pylipp ?

@fhenrich33
Copy link
Contributor

fhenrich33 commented Dec 2, 2024

Thanks for the ADR @pylipp!

I vouch for react-i18next, as it's the most widely supported by the React community overall. A plethora of plugins and code are built on top of it, and it's my personal preference because it's decoupled from React implementation-wise (compared to react-intl).

Edit: by decoupled, I was thinking more in the sense of testability and ease of building utilities on top of it.

@pylipp
Copy link
Contributor Author

pylipp commented Dec 2, 2024

Might be worth revisiting TMS from a non-developer POV. Would integrating with a TMS add time to the dev estimate?

@aerinsol yes, integrating a TMS would add time to the initial dev estimate I think. The suggested TMSs are cloud-based, so there needs to be some integration into with the repo and/or CI.

I vouch for react-i18next, as it's the most widely supported by the React community overall. A plethora of plugins and code are built on top of it, and it's my personal preference because it's decoupled from React implementation-wise (compared to react-intl).

Thanks for your assessment @fhenrich33 it's valid point in favor of react-i18next to be framework-agnostic (even though we are very unlikely to move away from react, as Roanna said during SU). @HaGuesto also named react-i18next as his favorite.

@pylipp
Copy link
Contributor Author

pylipp commented Dec 2, 2024

@aerinsol I just updated the section about the effort estimation because I noticed a confusing missing newline in there, too

@pylipp pylipp changed the title Add first version of i18n ADR Add i18n ADR Dec 2, 2024
@pylipp pylipp marked this pull request as ready for review December 10, 2024 15:22
@aerinsol
Copy link
Member

My Trello Power-up isn't working, but here's the corresponding card: https://trello.com/c/jkdpDyyX

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants