-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add i18n ADR #1794
base: master
Are you sure you want to change the base?
Add i18n ADR #1794
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Might be worth revisiting TMS from a non-developer POV. Would integrating with a TMS add time to the dev estimate @pylipp ?
Thanks for the ADR @pylipp! I vouch for Edit: by decoupled, I was thinking more in the sense of testability and ease of building utilities on top of it. |
@aerinsol yes, integrating a TMS would add time to the initial dev estimate I think. The suggested TMSs are cloud-based, so there needs to be some integration into with the repo and/or CI.
Thanks for your assessment @fhenrich33 it's valid point in favor of react-i18next to be framework-agnostic (even though we are very unlikely to move away from react, as Roanna said during SU). @HaGuesto also named react-i18next as his favorite. |
@aerinsol I just updated the section about the effort estimation because I noticed a confusing missing newline in there, too |
My Trello Power-up isn't working, but here's the corresponding card: https://trello.com/c/jkdpDyyX |
Doc as rendered markdown.
Superceding this doc.