Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capture otel metrics for OAuth errors and add logging to stderr #3437

Merged
merged 27 commits into from
Dec 25, 2024

Conversation

niwsa
Copy link
Member

@niwsa niwsa commented Dec 16, 2024

What does this PR do?

Add metrics for OAuth related errors plus add missing stderr logging.

Type of change

  • Updated dependencies
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How should this be tested?

  • Existing unit tests

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code and corrected any misspellings
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@niwsa niwsa added the enhancement New feature or request label Dec 16, 2024
@niwsa niwsa changed the title Add oauth tracing Capture otel metrics for OAuth errors and add logging to stderr Dec 16, 2024
@niwsa niwsa marked this pull request as ready for review December 20, 2024 20:15
@niwsa niwsa requested a review from a team December 20, 2024 20:15
@deepakprabhakara deepakprabhakara merged commit 3f586ef into main Dec 25, 2024
6 checks passed
@deepakprabhakara deepakprabhakara deleted the add-oauth-tracing branch December 25, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants