Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added DISABLE_SSO_TRACE flag to control logging to sso trace #3443

Merged
merged 8 commits into from
Dec 18, 2024

Conversation

nitendra-new
Copy link
Contributor

What does this PR do?

Fixes # (issue)

Type of change

  • Updated dependencies
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How should this be tested?

  • Existing unit tests

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code and corrected any misspellings
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@nitendra-new nitendra-new requested review from deepakprabhakara, niwsa and a team December 17, 2024 12:25
npm/src/controller/oauth.ts Outdated Show resolved Hide resolved
lib/env.ts Outdated Show resolved Hide resolved
Copy link
Member

@deepakprabhakara deepakprabhakara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

requested more changes

@deepakprabhakara deepakprabhakara merged commit 93d6cd4 into main Dec 18, 2024
5 checks passed
@deepakprabhakara deepakprabhakara deleted the feature-disable-ssotrace-info branch December 18, 2024 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants