Add Interactive Proof Debugger FeatureComplete proof debugging system…#133
Add Interactive Proof Debugger FeatureComplete proof debugging system…#133yaswanth169 wants to merge 1 commit intoboyland:masterfrom
Conversation
boyland
left a comment
There was a problem hiding this comment.
Thanks for your work! It seems very interesting.
I'm open to including your changes, but you have lots of changes of existing files that merely update the formatting. Some of the formatting changes are fine, but others harmful. But in any case, formatting changes should not be mixed with semantic changes. Please update your pull request to change existing files only as needed for your extension, not because your version of VSC wants "if (condition) action" converted to add a newline.
602bcdf to
15bc66c
Compare
Complete proof debugging system with JSON export. Modified Files (minimal semantic changes only): - Main.java: Added --proof-debug flag parsing and JSON export (21 lines) - Theorem.java: Added beginTheorem/endTheorem hooks (8 lines) - Derivation.java: Added pushDerivation/popDerivation hooks (5 lines) - ProofDebugger.java: Added stub methods for minimal tracking New Files: - 6 debugger package classes (ProofState, DerivationStep, etc.) - PROOF_DEBUGGER_README.md documentation Testing: - All files compile successfully - Feature test: JSON export working correctly - Backward compatible (no impact when flag not used) Total changes: ~34 lines across 3 existing files Zero formatting changes to existing code Zero Javadoc comment changes
15bc66c to
4f3d693
Compare
|
Thanks for the detailed review on PR #133. I’ve fully revised the PR to address the formatting concerns. What changed
Current scope
Verification
This version is strictly limited to enabling JSON-based proof debugging. A separate PR will introduce the interactive visualization tool that consumes this output. |
|
Hi @boyland , |
|
Thanks for your offer. I'm going to take a look when I get a chance. I am most interested in getting the earlier PR figured out, but it seems you've have pulled back to the scope of your changes, so I want to honor that by another review. But not yet. |
Summary
This PR adds a proof debugging feature that captures the complete execution state of SASyLF proofs and exports them to JSON format for visualization and analysis.
Features
--proof-debugImplementation
New Package:
edu.cmu.cs.sasylf.debugger(6 classes, 868 lines)Modified Files (46 lines total):
--proof-debugflag and JSON outputTesting
✓ All existing regression tests pass
✓ Feature tested on: sum.slf, lambda.slf, featherweight-java.slf
✓ JSON output validated
✓ Backward compatibility confirmed (no flag = no export)
Example Usage