Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #34 : Support AppSync as resource in CloudCatalog #35

Merged
merged 5 commits into from
Feb 4, 2024

Conversation

debae
Copy link
Contributor

@debae debae commented Feb 1, 2024

Motivation

Added support for AppSync in CloudCatalog instead of having it as a generic resource.

@debae debae requested a review from boyney123 as a code owner February 1, 2024 20:20
Copy link

changeset-bot bot commented Feb 1, 2024

⚠️ No Changeset found

Latest commit: 2914379

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@boyney123
Copy link
Owner

This is an EPIC contribution, thank you so much, Will get your branch checked out and test things my side, but very cool to see this addition.

@boyney123
Copy link
Owner

Just tried this, working great, had to change a few things, but mainly working! Going to merge this, we can also edit/change if we find issues.

Thanks for adding docs and tests too, great work.

@boyney123 boyney123 merged commit fb0b63c into boyney123:main Feb 4, 2024
6 checks passed
@boyney123
Copy link
Owner

@all-contributors add @debae for code,doc,ideas

Copy link
Contributor

@boyney123

I've put up a pull request to add @debae! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants