-
-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add !mtr command implementation #38
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job, noticed only one minor issue.
const Table = require('tty-table'); | ||
const log = require('log4js').getLogger('mtr'); | ||
|
||
const IPG_ADDRESS = process.env.IPG_ADDRESS || 'https://sites.google.com/site/mtgfamiliar/rules/MagicTournamentRules-light.html'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IPG_ADDRESS
?
if (/Format Deck Construction$/.test(title)) { | ||
// Asking a bot for the banlist has to be one of the worst ways to inquire about card legality that I can imagine, | ||
// defer handling this until I'm really bored and redirect people to the annotated mtr in the meantime | ||
return `You can find the full text of ${title} on <${this.location}${number.replace('.', '-')}>`; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haha, very nice. 😁 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Come to think of it, this is actually a separate issue: #18
Solves #37 and #11