Added lint through GH Action

[RishiKumarRay]

#3

[braaar]

The action says this:

Run sibiraj-s/action-eslint@v2
Notice: No files found. Skipping.

Is something not set up properly, perhaps?

https://github.com/braaar/jam-assistant/runs/4920799004?check_suite_focus=true#step:5:1

[braaar]

Perhaps we need an .eslintrc?

[RishiKumarRay]

@braaar exactly i feel so too, we need that file

[braaar]

I can set up eslint later and then we'll merge this action afterwards

[RishiKumarRay]

@braaar I tried adding eslint file , maybe you can have a lookout at that file and check it if there are any changes

[braaar]

@braaar I tried adding eslint file , maybe you can have a lookout at that file and check it if there are any changes

Careful! In this project we are using yarn, so we don't want that npm package-lock.json file.

Where did you source this eslint config? Can you describe how strict it is, which types of rules it has set up?

Personally I like very strict linting which throws errors for almost everything. I don't like having a bunch of linter warnings just sitting around.

[RishiKumarRay]

@braaar maybe i haven't done properly , it seems to add lint and preety you have to add lint and preety file so let me know when you add this than i will work on the github actions of that

[braaar]

@braaar maybe i haven't done properly , it seems to add lint and preety you have to add lint and preety file so let me know when you add this than i will work on the github actions of that

Sounds good. We'll take it one step at a time, no worries.

[simenandre]

Should probably remove package-lock.json

[simenandre]

Suggested change

	{
	"extends": [
	"eslint:recommended",
	"plugin:import/errors",
	"plugin:react/recommended",
	"plugin:jsx-a11y/recommended"
	],
	"plugins": ["react", "import", "jsx-a11y"],
	"rules": {
	"react/prop-types": 0,
	"indent": ["error", 2],
	"linebreak-style": 1,
	"quotes": ["error", "double"]
	},
	"parserOptions": {
	"ecmaVersion": 2021,
	"sourceType": "module",
	"ecmaFeatures": {
	"jsx": true
	}
	},
	"env": {
	"es6": true,
	"browser": true,
	"node": true
	},
	"settings": {
	"react": {
	"version": "detect"
	}
	}
	}
	{
	"extends": "@bjerk/eslint-config"
	}

[simenandre]

Suggested change

	- uses: sibiraj-s/action-eslint@v2
	with:
	eslint-args: '--ignore-path=.gitignore --quiet'
	extensions: 'js,jsx,ts,tsx'
	annotations: true
	- run: yarn lint

Should probably use a NPM script, no need for a special Github Action.