Enable golangci-lint #187
Open
Enable golangci-lint #187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a GitHub action to run golangci-lint. * Fixup or mark TODO various linting issues. Signed-off-by: SuperQ <[email protected]>
|
Thanks! I'm hoping we could hold off on a linter scrub until after the existing PR's are burnt down, since that adds to the workload of having to rebase things randomly, is that okay? |
|
Fine with me. Happy to rebase and lint later. |
|
Anything I can do to help with getting things moving again? |
|
@SuperQ This is mostly on me. After getting started I got sick twice then threw my back out. working to unjam things this month. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a GitHub action to run golangci-lint.