add to carbon: pco2 decomp and potential #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bradyrx
reviewed
Feb 7, 2019
bradyrx
requested changes
Feb 7, 2019
|
@aaronspring Two simple edits and then this will be ready to merge. |
|
Thanks for the additions, this is great. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I also added a primary production notebook with functions I use to understand the drivers of primary production, but these are our model specific functions of nutrient limitation and light-temp co-limitation. this is more a suggestion, but I am unsure whether this can be easily generalized to many models.
This PR holds: