Report distance from track origin #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alessandrofelder
approved these changes
Dec 18, 2023
Co-authored-by: Alessandro Felder <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting a pull request (PR), please read the contributing guide.
Description
What is this PR
Why is this PR needed?
This PR calculates the distance along the spline fit from the first point. This allows the user to know that e.g. point 40 is 400um from the first point, or find out the total length of the track.
References
Closes #37
How has this PR been tested?
Manually tested & automated tests updated.
Is this a breaking change?
It could break downstream workflows if they rely on csv column ordering, but this would be easily fixed.
Does this PR require an update to the documentation?
Yes - brainglobe/brainglobe.github.io#128
Checklist: