Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pinned numpy to < 2.0 #187

Merged
merged 1 commit into from
Aug 7, 2024
Merged

Pinned numpy to < 2.0 #187

merged 1 commit into from
Aug 7, 2024

Conversation

IgorTatarnikov
Copy link
Member

Before submitting a pull request (PR), please read the contributing guide.

Please fill out as much of this template as you can, but if you have any problems or questions, just leave a comment and we will help out :)

Description

What is this PR

  • Bug fix
  • Addition of a new feature
  • Other

Why is this PR needed?
Tests were failing due to issues relating to numpy>=2.0.

What does this PR do?
Temporarily pin numpy < 2.0.

References

Please reference any existing issues/PRs that relate to this PR.

How has this PR been tested?

All tests pass when run locally in a fresh environment with numpy 1.26.3

Is this a breaking change?

No

Does this PR require an update to the documentation?

No=

Checklist:

  • The code has been tested locally
  • Tests have been added to cover all new functionality (unit & integration)
  • The documentation has been updated to reflect any changes
  • The code has been formatted with pre-commit

@IgorTatarnikov IgorTatarnikov requested a review from a team August 7, 2024 13:54
@alessandrofelder alessandrofelder merged commit 1755ec5 into main Aug 7, 2024
14 checks passed
@alessandrofelder alessandrofelder deleted the pin-numpy-version branch August 7, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants