Add argsparse function for string input #128
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is this PR
Why is this PR needed?
Some argparse parameters in
workflowsaccept a string or None. E.g.torch_device. This adds support for providingnoneorNoneas input in argparse and converts it to None.Similarly, it makes the float and int functions also accept them.
If users don't provide those arg, these args will typically default to
None. But sometimes, you may want to explicitly provide the arg, but set it to None. Or if you programmatically set the arg when calling the command line in a script, you may want to be able to always set the arg. Presently, if you wanted the default None, you'd need to have dropped that parameter.What does this PR do?
Adds the string parser and makes str, int, and float accept none and it's variations as explicit values, instead of only allowing it from the default value.
References
This is required for brainglobe/brainglobe-workflows#150.
How has this PR been tested?
I tested it locally.
Is this a breaking change?
No, it only expands input.
Does this PR require an update to the documentation?
No.
Checklist: