Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop py3.8, support 3.11 #101

Merged
merged 1 commit into from
Sep 28, 2023
Merged

drop py3.8, support 3.11 #101

merged 1 commit into from
Sep 28, 2023

Conversation

alessandrofelder
Copy link
Member

@alessandrofelder alessandrofelder commented Sep 28, 2023

Description

What is this PR

  • Bug fix
  • Addition of a new feature
  • Other

Why is this PR needed?
We adhere to NEP 29 (and support for 3.8 was causing me problems cross-Python-version compatibility with importlib.resources in #91 )

What does this PR do?
Drop Python 3.8 support and optimistically support 3.11 (napari supports 3.11 for a few months now, I think).

References

Closes #102

How has this PR been tested?

Is this a breaking change?

Yes, for Python 3.8 users.

Does this PR require an update to the documentation?

Adherence to NEP 29 already official in our developer conventions, so no.

Checklist:

  • The code has been tested locally
  • [n/a] Tests have been added to cover all new functionality (unit & integration)
  • [n/a] The documentation has been updated to reflect any changes
  • The code has been formatted with pre-commit

@alessandrofelder alessandrofelder self-assigned this Sep 28, 2023
@alessandrofelder alessandrofelder marked this pull request as ready for review September 28, 2023 11:19
@codecov
Copy link

codecov bot commented Sep 28, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (d353a1e) 97.30% compared to head (a204460) 97.30%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #101   +/-   ##
=======================================
  Coverage   97.30%   97.30%           
=======================================
  Files           7        7           
  Lines         371      371           
=======================================
  Hits          361      361           
  Misses         10       10           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alessandrofelder alessandrofelder merged commit 46a59eb into main Sep 28, 2023
12 checks passed
@alessandrofelder alessandrofelder deleted the drop-py38 branch September 28, 2023 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Adhere to NEP 29
2 participants