[Feature] Remove xfail in tests/.../test_connected_components_labelling.py

[IgorTatarnikov]

Is your feature request related to a problem? Please describe.
Currently, tests are marked as XFAIL with two parameter sets that shouldn't pass. We should ensure the tests fail in the expected manner in a separate test.

Describe the solution you'd like
Separate the parameter sets that are marked as XFAIL into a separate test that asserts a specific failure mode.

cellfinder/tests/core/test_unit/test_detect/test_filters/test_volume_filters/test_connected_components_labelling.py

Lines 15 to 21 in e3802a4

	(254, np.uint16), # results in < 2**16 structures, so not a problem
	pytest.param(
	256, np.uint16, marks=pytest.mark.xfail
	), # results in 2**16 structures, so last structure gets labelled 0
	pytest.param(
	258, np.uint16, marks=pytest.mark.xfail
	), # results in > 2**16 structures, so two structures with label 1

[AlgoFoe]

Hi @IgorTatarnikov, I am interested in taking this on if it’s not already being worked on.
I have reviewed the issue, and I think I can help fix it. Could you please confirm if someone is already assigned or point me to relevant modules/tests to start with? Thanks!

[IgorTatarnikov]

I don't think this is being worked on currently.

The solution here would be to separate the inputs that results in an error (256, np.uint16) and (258, np.uint16) into separate tests and assert the specific failure modes.

Currently, the tests may fail for an unrelated reason and this wouldn't be detected by the test suite.

[AlgoFoe]

Thanks for the clarification! I’ll work on replacing the xfail cases with explicit failure tests and open a PR shortly.

[AlgoFoe]

Hi @IgorTatarnikov! I have opened a PR for this, would appreciate a review when you have time.
Thanks!